-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve tkn task spec locally #1885
Conversation
Signed-off-by: Matej Vasek <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Matej Vasek <[email protected]>
@lance PTAL |
@jrangelramos please test this. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1885 +/- ##
==========================================
+ Coverage 54.37% 62.93% +8.55%
==========================================
Files 106 107 +1
Lines 13737 13777 +40
==========================================
+ Hits 7470 8671 +1201
+ Misses 5511 4235 -1276
- Partials 756 871 +115
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: Matej Vasek <[email protected]>
/lgtm |
/retest |
I just tried.. and it works properly! Thanks. it is much quicker than previous approach. |
Changes