Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve tkn task spec locally #1885

Merged
merged 3 commits into from
Jul 24, 2023
Merged

fix: resolve tkn task spec locally #1885

merged 3 commits into from
Jul 24, 2023

Conversation

matejvasek
Copy link
Contributor

@matejvasek matejvasek commented Jul 24, 2023 •
edited
Loading

Changes

  • Remove Git task resolver and resolve the task specification locally. This is more reliable, git resolver is timing out on some clusters because git-clone is slow operation.

@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 24, 2023
@knative-prow
Copy link

knative-prow bot commented Jul 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested a review from navidshaikh July 24, 2023 16:09
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2023
@matejvasek matejvasek requested review from lkingland and removed request for navidshaikh July 24, 2023 16:09
@matejvasek
fixup: remove unused import
04f5568 
Signed-off-by: Matej Vasek <[email protected]>
@matejvasek
Copy link
Contributor Author

@lance PTAL

@matejvasek
Copy link
Contributor Author

@jrangelramos please test this.

@matejvasek matejvasek added this to the Release 1.11 milestone Jul 24, 2023
@codecov
Copy link

codecov bot commented Jul 24, 2023 •
edited
Loading

Codecov Report

Patch coverage: 68.75% and project coverage change: +8.55 🎉

Comparison is base (0def26f) 54.37% compared to head (1a4ab33) 62.93%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1885      +/-   ##
==========================================
+ Coverage   54.37%   62.93%   +8.55%     
==========================================
  Files         106      107       +1     
  Lines       13737    13777      +40     
==========================================
+ Hits         7470     8671    +1201     
+ Misses       5511     4235    -1276     
- Partials      756      871     +115
Flag Coverage Δ
e2e-test 35.48% <0.00%> (?)
e2e-test-oncluster 30.79% <68.75%> (+0.08%) ⬆️
e2e-test-oncluster-runtime 25.71% <68.75%> (?)
e2e-test-runtime-go 25.86% <0.00%> (?)
e2e-test-runtime-node 26.89% <0.00%> (?)
e2e-test-runtime-python 26.89% <0.00%> (?)
e2e-test-runtime-quarkus 27.01% <0.00%> (?)
e2e-test-runtime-springboot 26.03% <0.00%> (?)
e2e-test-runtime-typescript 27.01% <0.00%> (?)
integration-tests 51.49% <68.75%> (?)
unit-tests-macos-latest 49.23% <68.75%> (?)
unit-tests-ubuntu-latest 50.06% <68.75%> (?)
unit-tests-windows-latest 49.25% <68.75%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/pipelines/tekton/templates.go 71.37% <68.75%> (-0.05%) ⬇️

... and 31 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lance
Copy link
Member

lance commented Jul 24, 2023

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2023
@matejvasek
Copy link
Contributor Author

/retest

@knative-prow knative-prow bot merged commit 8b46151 into knative:main Jul 24, 2023
37 checks passed
@jrangelramos
Copy link
Contributor

jrangelramos commented Jul 24, 2023 •
edited
Loading

I just tried.. and it works properly! Thanks. it is much quicker than previous approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik Awaiting requested review from zroubalik

@lance lance Awaiting requested review from lance

@jrangelramos jrangelramos Awaiting requested review from jrangelramos

@aslom aslom Awaiting requested review from aslom

@salaboy salaboy Awaiting requested review from salaboy

@lkingland lkingland Awaiting requested review from lkingland

Assignees

@lance lance

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
Release 1.11
Development

Successfully merging this pull request may close these issues.
3 participants
@matejvasek @lance @jrangelramos